Re: [PATCH] Be more careful with objects directory permissions on clone

From: Johannes Sixt <j.sixt@viscovery.net>
Date: May 6, 2008, 08:08 UTC
Message-ID: <4820121A.9090606@viscovery.net>
In-Reply-To: <fvp14f$8v0$1@ger.gmane.org>

Jakub Narebski schrieb:

Show 10 quoted lines

> Mark Hills wrote:
> 
>> -               find objects -depth -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \
>> +               # Create dirs using umask and permissions and destination
>> +               find objects -type d -print | (cd "$GIT_DIR" && xargs mkdir -p) &&
>> +               # Copy existing 0444 permissions on content
>> +               find objects ! -type d -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \
> 
> By the way, it is important that previous version had -depth, and
> proposed one doesn't? Was it about creating directories before files?

-depth means that directory names are listed *after* their content. Consequently, it was about setting modification times and permissions on directories *after* all of their content is created at the destination.

The intent of the new version is to not copy permissions of directories; and since the modification times don't matter, the absence of -depth is ok.

-- Hannes