git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Be more careful with objects directory permissions on clone

From
Johannes Sixt <j.sixt@viscovery.net>
Date
May 5, 2008, 09:01 UTC
Message-ID
<481ECCF0.6080308@viscovery.net>
In-Reply-To
<alpine.BSO.1.10.0805041234570.5819@zrgural.vwaro.pbz>
Mark Hills schrieb:
Show 7 quoted lines
> Honour the setgid and umask when re-creating the objects directory
> at the destination.
> 
> cpio in copy-pass mode aims to copy file permissions which causes this
> problem and cannot be disabled. Be explicit by copying the directory
> structure first, honouring the permissions at the destination, then copy
> the files with their existing read-only permissions.
...
Show 8 quoted lines
>          cd "$repo" &&
> -        find objects -depth -print | cpio $cpio_quiet_flag -pumd$l
> "$GIT_DIR/" || \
> +        # Create dirs using umask and permissions and destination
> +        find objects -type d -print | (cd "$GIT_DIR" && xargs mkdir -p) &&
> +        # Copy 0444 permissions on files
> +        find objects -type f -print | cpio $cpio_quiet_flag -pumd$l
> "$GIT_DIR/" || \
Wouldn't that be better:
	find objects ! -type d -print | cpio ...
?
-- Hannes
Previous: Mark HillsNext: Mark Hills
Message 2 of 10 in “Be more careful with objects directory permissions on clone”
  1. Be more careful with objects directory permissions on cloneMark Hills, May 4, 2008
  2. Johannes SixtMay 5, 2008
  3. Mark HillsMay 5, 2008
  4. Johannes SixtMay 5, 2008
  5. Mark HillsMay 5, 2008
  6. Johannes SixtMay 5, 2008
  7. Mark HillsMay 5, 2008
  8. Junio C HamanoMay 6, 2008
  9. Jakub NarebskiMay 6, 2008
  10. Johannes SixtMay 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.