git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 18, 2012, 16:30 UTC
Message-ID
<7vobqpknoq.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4F8E539F.7030902@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 6 quoted lines
>> It sounds like the real problem is not the use of a configurable shell,
>> but rather the use of an absolute path. Should you maybe try to pass the
>> basename of SHELL_PATH? ...
>
> I thought about offering a customization point, but decided that it is not
> worth the hassle...

I think you meant by the above that the installer could offer the user to choose where to place the shell, and if that is the case, I agree it would probably not worth it.

There is one thing I am confused about your response, though. I thought the suggestion by Peff was to build your binary with "make SHELL_PATH=sh" (not "make SHELL_PATH=/bin/sh"). I do not know if that works or does not work (I do not see why not, though), but in either case offering a new customization point sounds like a separate issue.

Previous: Jeff KingNext: Johannes Sixt
Message 14 of 16 in “Use SHELL_PATH from build system in run_command.c:prepare_shell_cmd”
  1. Use SHELL_PATH from build system in run_command.c:prepare_shell_cmdBen Walton, Mar 31, 2012
  2. Jonathan NiederMar 31, 2012
  3. Junio C HamanoMar 31, 2012
  4. Jonathan NiederMar 31, 2012
  5. Junio C HamanoMar 31, 2012
  6. Junio C HamanoMar 31, 2012
  7. Do not use SHELL_PATH from build system in prepare_shell_cmd on WindowsJohannes Sixt, Apr 17, 2012
  8. Ben WaltonApr 17, 2012
  9. Johannes SixtApr 17, 2012
  10. Ben WaltonApr 17, 2012
  11. Jeff KingApr 17, 2012
  12. Johannes SixtApr 18, 2012
  13. Jeff KingApr 18, 2012
  14. Junio C HamanoApr 18, 2012
  15. Johannes SixtApr 19, 2012
  16. Junio C HamanoApr 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.