From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 18 Apr 2012 16:30:13 GMT
Subject: Re: [PATCH] Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows
Message-ID: <7vobqpknoq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F8E539F.7030902@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

>> It sounds like the real problem is not the use of a configurable shell,
>> but rather the use of an absolute path. Should you maybe try to pass the
>> basename of SHELL_PATH? ...
>
> I thought about offering a customization point, but decided that it is not
> worth the hassle...

I think you meant by the above that the installer could offer the user to
choose where to place the shell, and if that is the case, I agree it would
probably not worth it.

There is one thing I am confused about your response, though.  I thought
the suggestion by Peff was to build your binary with "make SHELL_PATH=sh"
(not "make SHELL_PATH=/bin/sh").  I do not know if that works or does not
work (I do not see why not, though), but in either case offering a new
customization point sounds like a separate issue.