git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Apr 19, 2012, 05:36 UTC
Message-ID
<4F8FA453.8050807@viscovery.net>
In-Reply-To
<7vobqpknoq.fsf@alter.siamese.dyndns.org>
Am 4/18/2012 18:30, schrieb Junio C Hamano:
Show 5 quoted lines
> There is one thing I am confused about your response, though.  I thought
> the suggestion by Peff was to build your binary with "make SHELL_PATH=sh"
> (not "make SHELL_PATH=/bin/sh").  I do not know if that works or does not
> work (I do not see why not, though), but in either case offering a new
> customization point sounds like a separate issue.

I tried this, and it does not work. (Shell scripts' shbang line would end up as '#!sh', and at least bash does not like to run such scripts.)

The alternative is to customize the -DSHELL_PATH=... compiler option for Windows, and that is primarily what I don't like: It would mean that either the name "SHELL_PATH" has different meaning in C code and the Makefile, or we need a new name for the C macro. (The latter would be "a new customization point".)

I learn from this conversation that I should note failed alternatives more frequently in the commit message to save reviewers' time.

-- Hannes
Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 16 in “Use SHELL_PATH from build system in run_command.c:prepare_shell_cmd”
  1. Use SHELL_PATH from build system in run_command.c:prepare_shell_cmdBen Walton, Mar 31, 2012
  2. Jonathan NiederMar 31, 2012
  3. Junio C HamanoMar 31, 2012
  4. Jonathan NiederMar 31, 2012
  5. Junio C HamanoMar 31, 2012
  6. Junio C HamanoMar 31, 2012
  7. Do not use SHELL_PATH from build system in prepare_shell_cmd on WindowsJohannes Sixt, Apr 17, 2012
  8. Ben WaltonApr 17, 2012
  9. Johannes SixtApr 17, 2012
  10. Ben WaltonApr 17, 2012
  11. Jeff KingApr 17, 2012
  12. Johannes SixtApr 18, 2012
  13. Jeff KingApr 18, 2012
  14. Junio C HamanoApr 18, 2012
  15. Johannes SixtApr 19, 2012
  16. Junio C HamanoApr 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.