Re: [PATCH] Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows

From: Ben Walton <bwalton@artsci.utoronto.ca>
Date: Apr 17, 2012, 13:45 UTC
Message-ID: <1334670128-sup-4966@pinkfloyd.chass.utoronto.ca>
In-Reply-To: <4F8D15B9.70803@viscovery.net>

Excerpts from Johannes Sixt's message of Tue Apr 17 03:03:21 -0400 2012:

Hi Hannes,

> The recent change to use SHELL_PATH instead of "sh" to spawn shell
> commands is not suited for Windows:

Ah yes, I can see how that would be undesirable on Windows.

Show 6 quoted lines

> +#ifndef WIN32
>          nargv[nargc++] = SHELL_PATH;
> +#else
> +        nargv[nargc++] = "sh";
> +#endif
>          nargv[nargc++] = "-c";

A minor style question: Would this conditional code not be better if it were up where the fallback SHELL_PATH is set? That would leave this code block #ifdef free while still avoiding the breakage on Windows.

Admittedly, it's a very minor point and possibly entirely a personal preference.

Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302