git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: Produce better output with --inline or --attach

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 30, 2008, 18:52 UTC
Message-ID
<7vmyjz5hmc.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.LSU.1.00.0807301624410.3486@wbgn129.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
>> The second change is to always write the line termination character 
>> (default: newline) even when using --inline or --attach. This is simply 
>> to improve the aesthetics of the resulting message. When using --inline 
>> an email client should render the resulting message identically to the 
>> non-inline version. And when using --attach this adds a blank line 
>> preceding the attachment in the email, which is visually attractive.
>
> It appears that your patch has one uncontroversial and one controversial 
> part, then.
Could you elaborate what's controversial about this?
Previous: Jeff King
Message 8 of 8 in “format-patch: Produce better output with --inline or --attach”
  1. format-patch: Produce better output with --inline or --attachKevin Ballard, Jul 29, 2008
  2. Jeff KingJul 30, 2008
  3. format-patch: Produce better output with --inline or --attachKevin Ballard, Jul 30, 2008
  4. Johannes SchindelinJul 30, 2008
  5. Kevin BallardJul 30, 2008
  6. Kevin BallardJul 30, 2008
  7. Jeff KingJul 31, 2008
  8. Junio C HamanoJul 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.