Re: [PATCH] format-patch: Produce better output with --inline or --attach

From: Jeff King <peff@peff.net>
Date: Jul 30, 2008, 05:24 UTC
Message-ID: <20080730052401.GC4034@sigill.intra.peff.net>
In-Reply-To: <1217375356-80287-1-git-send-email-kevin@sb.org>

On Tue, Jul 29, 2008 at 04:49:16PM -0700, Kevin Ballard wrote:

Show 5 quoted lines

> The first is to write a newline preceding the boundary. This is needed
> because MIME defines the encapsulation boundary as including the
> preceding CRLF (or in this case, just LF), so we should be writing
> one. Without this, the last newline in the pre-diff content is
> consumed instead.

Hmm. I am surprised we haven't had more bug reports about this, but perhaps these features aren't used too frequently. But I double checked the MIME specs just to be sure, and you are definitely right.

> The second change is to always write the line termination character (default: newline)

Can you please wrap your commit messages at some more reasonable length? This line is 86 characters long.

-Peff