git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: Produce better output with --inline or --attach

From
Jeff King <peff@peff.net>
Date
Jul 31, 2008, 05:52 UTC
Message-ID
<20080731055229.GB17652@sigill.intra.peff.net>
In-Reply-To
<B805BDA1-6C22-4488-B5F5-6DA8CC729C06@sb.org>
On Wed, Jul 30, 2008 at 11:30:32AM -0700, Kevin Ballard wrote:
Show 8 quoted lines
>>> The second change is to always write the line termination character
>>> (default: newline) even when using --inline or --attach. This is  
>> It appears that your patch has one uncontroversial and one  
>> controversial
>> part, then.
> Is this controversial? Nobody's objected so far. My goal with this change 
> is to make the --inline output render exactly the same as the default 
> output in a mail client. I can't think of any downside.

No. I didn't comment on it in my earlier response because I don't really care. But I certainly have no problem with it, and it is probably an improvement.

-Peff
Previous: Kevin BallardNext: Junio C Hamano
Message 7 of 8 in “format-patch: Produce better output with --inline or --attach”
  1. format-patch: Produce better output with --inline or --attachKevin Ballard, Jul 29, 2008
  2. Jeff KingJul 30, 2008
  3. format-patch: Produce better output with --inline or --attachKevin Ballard, Jul 30, 2008
  4. Johannes SchindelinJul 30, 2008
  5. Kevin BallardJul 30, 2008
  6. Kevin BallardJul 30, 2008
  7. Jeff KingJul 31, 2008
  8. Junio C HamanoJul 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.