From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Jul 2008 18:52:59 GMT
Subject: Re: [PATCH] format-patch: Produce better output with --inline or --attach
Message-ID: <7vmyjz5hmc.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.1.00.0807301624410.3486@wbgn129.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> The second change is to always write the line termination character 
>> (default: newline) even when using --inline or --attach. This is simply 
>> to improve the aesthetics of the resulting message. When using --inline 
>> an email client should render the resulting message identically to the 
>> non-inline version. And when using --attach this adds a blank line 
>> preceding the attachment in the email, which is visually attractive.
>
> It appears that your patch has one uncontroversial and one controversial 
> part, then.

Could you elaborate what's controversial about this?