Re: [PATCH try 2] t1301-shared-repo.sh: don't let a default ACL interfere with the test

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 15, 2008, 06:30 UTC
Message-ID: <7vmyh64bgy.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <48F589EC.6050307@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 14 quoted lines

> Junio C Hamano schrieb:
> ...
>>> +# Remove a default ACL from the test dir if possible.
>>> +setfacl -k . 2>/dev/null
>>> +
>> 
>> Makes me wonder why this is _not_ inside test-lib.sh where it creates the
>> test (trash) directory.  That way, you would cover future tests that wants
>> to see a saner/simpler POSIX permission behaviour, wouldn't you?
>
> But that would also paper over unanticipated bad interactions with strange
> ACLs that people might set, wouldn't it? By not placing this into
> test-lib.sh there is a higher chance that such an interaction is revealed,
> and we can react on it (educate users or fix the code).

What do you exactly mean by "educate users or fix the code"? For example, by not putting this setfacl in test-lib.sh, t1301 revealed that with a default ACL higher up, "git init --shared" would not work as expected.

Then what?

 - Do you mean, by "educate users", that we teach users not to play fun
   games with ACL in a git controled working tree?

 - Do you mean, by "fix the code", that we teach adjust_shared_perm() to
   deal with ACL?