git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH try 4] t1301-shared-repo.sh: don't let a default ACL interfere with the test

From
Matt McCutchen <matt@mattmccutchen.net>
Date
Oct 17, 2008, 02:32 UTC
Message-ID
<1224210734.2952.42.camel@mattlaptop2.local>
In-Reply-To
<7vzll5jepj.fsf@gitster.siamese.dyndns.org>

This test creates files with several different umasks and expects their permissions to be initialized according to the umask, so a default ACL on the trash directory (which overrides the umask for files created in that directory) causes the test to fail. To avoid that, remove the default ACL if possible with setfacl(1).

Signed-off-by: Matt McCutchen <matt@mattmccutchen.net>
---
Fix typo in commit message.  I'm sorry for the noise.
 t/t1301-shared-repo.sh |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index dc85e8b..2275caa 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -7,6 +7,9 @@ test_description='Test shared repository initialization'
 
 . ./test-lib.sh
 
+# Remove a default ACL from the test dir if possible.
+setfacl -k . 2>/dev/null
+
 # User must have read permissions to the repo -> failure on --shared=0400
 test_expect_success 'shared = 0400 (faulty permission u-w)' '
 	mkdir sub && (
-- 
1.6.0.2.530.gb503b
Previous: Matt McCutchenNext: Matt McCutchen
Message 16 of 17 in “t1301-shared-repo.sh: don't let a default ACL interfere with the test”
  1. t1301-shared-repo.sh: don't let a default ACL interfere with the testMatt McCutchen, Oct 14, 2008
  2. t1301-shared-repo.sh: don't let a default ACL interfere with the testMatt McCutchen, Oct 14, 2008
  3. Junio C HamanoOct 14, 2008
  4. Matt McCutchenOct 14, 2008
  5. Deskin MillerOct 14, 2008
  6. Johannes SixtOct 15, 2008
  7. Junio C HamanoOct 15, 2008
  8. Johannes SixtOct 15, 2008
  9. Junio C HamanoOct 15, 2008
  10. Johannes SixtOct 15, 2008
  11. Junio C HamanoOct 16, 2008
  12. Matt McCutchenOct 17, 2008
  13. Junio C HamanoOct 17, 2008
  14. Matt McCutchenOct 17, 2008
  15. t1301-shared-repo.sh: don't let a default ACL interfere with the testMatt McCutchen, Oct 17, 2008
  16. t1301-shared-repo.sh: don't let a default ACL interfere with the testMatt McCutchen, Oct 17, 2008
  17. Matt McCutchenOct 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.