Re: [PATCH try 2] t1301-shared-repo.sh: don't let a default ACL interfere with the test

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 15, 2008, 06:13 UTC
Message-ID: <48F589EC.6050307@viscovery.net>
In-Reply-To: <7vzll66c5u.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 16 quoted lines

> Matt McCutchen <matt@mattmccutchen.net> writes:
>> diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
>> index dc85e8b..2275caa 100755
>> --- a/t/t1301-shared-repo.sh
>> +++ b/t/t1301-shared-repo.sh
>> @@ -7,6 +7,9 @@ test_description='Test shared repository initialization'
>>  
>>  . ./test-lib.sh
>>  
>> +# Remove a default ACL from the test dir if possible.
>> +setfacl -k . 2>/dev/null
>> +
> 
> Makes me wonder why this is _not_ inside test-lib.sh where it creates the
> test (trash) directory.  That way, you would cover future tests that wants
> to see a saner/simpler POSIX permission behaviour, wouldn't you?

But that would also paper over unanticipated bad interactions with strange ACLs that people might set, wouldn't it? By not placing this into test-lib.sh there is a higher chance that such an interaction is revealed, and we can react on it (educate users or fix the code).

-- Hannes