Re: [PATCH try 2] t1301-shared-repo.sh: don't let a default ACL interfere with the test

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 15, 2008, 08:10 UTC
Message-ID: <48F5A590.3050905@viscovery.net>
In-Reply-To: <7v7i8a47f6.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 17 quoted lines

> Johannes Sixt <j.sixt@viscovery.net> writes:
>>>  - Do you mean, by "educate users", that we teach users not to play fun
>>>    games with ACL in a git controled working tree?
>> Correct. In the case of a shared repository we can educate users not to
>> play with ACLs.
>>
>>>  - Do you mean, by "fix the code", that we teach adjust_shared_perm() to
>>>    deal with ACL?
>> Correct in principle, but we need not go this route in the case of shared
>> repositories because we better educate users.
> 
> If that is the case what difference does your suggestion of not putting it
> in test-lib.sh make?  We discourage users from playing ACL games, and we
> protect ourselves from such by making sure the trash directory used for
> running tests are not contaminated with ACL.  Wouldn't it make more sense
> to do so for all the tests, so that future test writers do not have to
> worry about it?

We have to decide case by case. In the case of shared directories it makes sense to suggest "do not play ACL games". In other cases, however, this suggestion could not work out that well, and a workaround in the code is the better solutions. But we do not know what those other cases are, and the test suite may be a tool to uncover them.

Perhaps I'm worrying too much because a case that warrants a change in the code would either have to happen frequently or be backed with very strong arguments that ACLs are required in that particular way. (And in both cases there would still have be conflicts in the way how git handles permissions - we wouldn't care otherwise.) But no such case has turned up so far.

-- Hannes