git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] make it possible to skip away from broken commits

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 2, 2009, 20:53 UTC
Message-ID
<7vmy8qe4ru.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20090602200731.3630.33652.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
Show 6 quoted lines
> This patch series adds a "--ratio=x/y" option to "git bisect skip" so
> that it is possible to skip away from an area were the commits cannot
> be tested.
>
> Note that in this series "--ratio=4" means the same as "--ratio=1/4".
> But I am not sure if this shortcut is worth it.

Actually my gut feeling is that a tweakable knob itself is worth it, because the user can never tell what the right value should be.

Especially without any documentation updates that explains what this ratio refers to ;-), but I suspect, unless the user is very familiar with how the revision graph bisection internally works, such an explanation would not help him find a skip ratio that is closer to the optimum than a random guess. Why not use a constant ratio (or perhaps a pair of alternating ratios) on "bisect skip" without any new options?

Previous: Christian CouderNext: H. Peter Anvin
Message 6 of 10 in “make it possible to skip away from broken commits”
  1. 0/4 make it possible to skip away from broken commitsChristian Couder, Jun 2, 2009
  2. 1/4 bisect: add parameters to "filter_skipped"Christian Couder, Jun 2, 2009
  3. 2/4 bisect: use the skip ratio to choose a commit away from a skipped commitChristian Couder, Jun 2, 2009
  4. 3/4 bisect: add "--ratio=<ratio>" option to "git bisect skip"Christian Couder, Jun 2, 2009
  5. 4/4 t6030: add test case for "git bisect skip --ratio=x/y"Christian Couder, Jun 2, 2009
  6. Junio C HamanoJun 2, 2009
  7. H. Peter AnvinJun 3, 2009
  8. Christian CouderJun 3, 2009
  9. Junio C HamanoJun 3, 2009
  10. Christian CouderJun 3, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.