From: Junio C Hamano Date: Tue, 02 Jun 2009 20:53:41 GMT Subject: Re: [PATCH 0/4] make it possible to skip away from broken commits Message-ID: <7vmy8qe4ru.fsf@alter.siamese.dyndns.org> In-Reply-To: <20090602200731.3630.33652.chriscool@tuxfamily.org> Christian Couder writes: > This patch series adds a "--ratio=x/y" option to "git bisect skip" so > that it is possible to skip away from an area were the commits cannot > be tested. > > Note that in this series "--ratio=4" means the same as "--ratio=1/4". > But I am not sure if this shortcut is worth it. Actually my gut feeling is that a tweakable knob itself is worth it, because the user can never tell what the right value should be. Especially without any documentation updates that explains what this ratio refers to ;-), but I suspect, unless the user is very familiar with how the revision graph bisection internally works, such an explanation would not help him find a skip ratio that is closer to the optimum than a random guess. Why not use a constant ratio (or perhaps a pair of alternating ratios) on "bisect skip" without any new options?