git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] make it possible to skip away from broken commits

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 3, 2009, 07:10 UTC
Message-ID
<7vbpp5dc8b.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4A25EA85.5090208@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
Show 11 quoted lines
> Junio C Hamano wrote:
>> Christian Couder <chriscool@tuxfamily.org> writes:
>> 
>>> This patch series adds a "--ratio=x/y" option to "git bisect skip" so
>>> that it is possible to skip away from an area were the commits cannot
>>> be tested.
>>>
>>> Note that in this series "--ratio=4" means the same as "--ratio=1/4".
>>> But I am not sure if this shortcut is worth it.
>> 
>> Actually my gut feeling is that a tweakable knob itself is worth it,
I meant "is not" worth it.
Show 6 quoted lines
>> because the user can never tell what the right value should be.
>> 
>> ...  Why not use a constant ratio (or perhaps a pair of alternating
>> ratios) on "bisect skip" without any new options?
>
> I would agree with this assessment....

Thanks for reading what I meant to say, even though I said quite opposite to what I meant to say ;-)

> When one gets down to a small number of points this could get weird, but
> as long as skip points are filtered (which looks like it's already being
> done) it should converge.

Yes; I think "the next point" selection after "skip" is (or at least can be handled as) a local thing. As long as the next point selection is not too close to the known-to-be-untestable commit we will have a reasonable coverage over the remainder of the history. Also I suspect that trying to be too clever will not help us very much and the end result would be affected more heavily by the distribution of untestable commits than how well these next points are chosen.

Previous: Christian CouderNext: Christian Couder
Message 9 of 10 in “make it possible to skip away from broken commits”
  1. 0/4 make it possible to skip away from broken commitsChristian Couder, Jun 2, 2009
  2. 1/4 bisect: add parameters to "filter_skipped"Christian Couder, Jun 2, 2009
  3. 2/4 bisect: use the skip ratio to choose a commit away from a skipped commitChristian Couder, Jun 2, 2009
  4. 3/4 bisect: add "--ratio=<ratio>" option to "git bisect skip"Christian Couder, Jun 2, 2009
  5. 4/4 t6030: add test case for "git bisect skip --ratio=x/y"Christian Couder, Jun 2, 2009
  6. Junio C HamanoJun 2, 2009
  7. H. Peter AnvinJun 3, 2009
  8. Christian CouderJun 3, 2009
  9. Junio C HamanoJun 3, 2009
  10. Christian CouderJun 3, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.