Re: [PATCH 0/4] make it possible to skip away from broken commits
- From
Christian Couder <chriscool@tuxfamily.org>
- Date
- Jun 3, 2009, 06:29 UTC
- Message-ID
- <200906030829.48470.chriscool@tuxfamily.org>
- In-Reply-To
- <7vmy8qe4ru.fsf@alter.siamese.dyndns.org>
Le Tuesday 02 June 2009, Junio C Hamano a écrit :
Show 10 quoted lines
> Christian Couder <chriscool@tuxfamily.org> writes: > > This patch series adds a "--ratio=x/y" option to "git bisect skip" so > > that it is possible to skip away from an area were the commits cannot > > be tested. > > > > Note that in this series "--ratio=4" means the same as "--ratio=1/4". > > But I am not sure if this shortcut is worth it. > > Actually my gut feeling is that a tweakable knob itself is worth it, > because the user can never tell what the right value should be.
You mean a boolean configuration variable like "bisect.skip_away" or a "--skip_away" switch to "git bisect start" or both?
Show 6 quoted lines
> Especially without any documentation updates that explains what this > ratio refers to ;-), but I suspect, unless the user is very familiar with > how the revision graph bisection internally works, such an explanation > would not help him find a skip ratio that is closer to the optimum than a > random guess. Why not use a constant ratio (or perhaps a pair of > alternating ratios) on "bisect skip" without any new options?
Ok, I will have a look at that too.
Thanks, Christian.