git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/28] clean-ups of static functions and returns

From
Junio C Hamano <junkio@cox.net>
Date
Aug 15, 2006, 01:54 UTC
Message-ID
<7vlkpqahlx.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<BAY110-F2347BACD15C6BACC34E839B84F0@phx.gbl>
"trajce nedev" <trajcenedev@hotmail.com> writes:
> So you're just going to continue passing numbers around in the hope
> that someday they'll be used for something?
>
> Trajce Nedev

It is more like "fearing someday we might modify the callees and they may start returning error codes".

Admittedly, "someday" has a tendency not to come, but making the callees void and changing the callers who are already checking the error codes to ignore what are returned from them somehow feel backwards and pushing that someday further into the future.

Either patches to implement the error checking in the callees, or arguments that particular callees the series touch do not have reasonably graceful error return path are welcome (the former advocating against and the latter advocating for the application of the patch).

Previous: trajce nedev
Message 10 of 10 in “clean-ups of static functions and returns”
  1. 00/28 clean-ups of static functions and returnsDavid Rientjes, Aug 14, 2006
  2. Jakub NarebskiAug 14, 2006
  3. David RientjesAug 14, 2006
  4. Johannes SchindelinAug 14, 2006
  5. Jakub NarebskiAug 14, 2006
  6. Junio C HamanoAug 14, 2006
  7. David RientjesAug 14, 2006
  8. Junio C HamanoAug 15, 2006
  9. trajce nedevAug 15, 2006
  10. Junio C HamanoAug 15, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.