Re: [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm

From: Junio C Hamano <junkio@cox.net>
Date: Jun 28, 2006, 18:59 UTC
Message-ID: <7virml14za.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vr719159v.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 15 quoted lines

> Marco Roeland <marco.roeland@xs4all.nl> writes:
>
>> In commit 6294a10 it was noted that "on x86-64 it seems that Git.xs does
>> not link without compiling the main git objects with -fPIC". Set it
>> therefore automatically on this platform.
>
> I agree with it in principle but was too lazy to do that myself.
> I wonder it should be inside Linux, though.
>
>>  ifeq ($(uname_S),Linux)
>>  	NO_STRLCPY = YesPlease
>> +	ifneq (,$(findstring x86_64,$(uname_M)))
>> +		USE_PIC = YesPlease
>> +	endif
>>  endif

In other words, I am wondering why you did not do this more obvious one:

        ifeq ($(uname_M),x86_64)
                USE_PIC = YesPlease
        endif

My suspicion is that you protected that in Linux on purpose because you know that my version would break for somebody else, or because you are trying to be cautious not to break other platforms you do not have access to, and I cannot tell which.