git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.xs

From
MRMarco Roeland <marco.roeland@xs4all.nl>
Date
Jun 28, 2006, 19:55 UTC
Message-ID
<20060628195518.GE5713@fiberbit.xs4all.nl>
In-Reply-To
<20060628192145.GD5713@fiberbit.xs4all.nl>

In commit 6294a10 it was noted that "on x86-64 it seems that Git.xs does not link without compiling the main git objects with -fPIC". Set it therefore automatically on this platform.

This patch does this only for _Linux_ x86-64, as that is the only x86-64 platform I have access to. But it might very well make sense on other x86-64 platforms, please test and report if you have such a platform.

Signed-off-by: Marco Roeland <marco.roeland@xs4all.nl>
---
This applies to 'pu'. It is an amended version from an earlier one
with a simplification from Junio and a clarification why it is Linux
specific at the moment. The title was also slightly improved.
---
 Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 2df5bd4..88cfe2b 100644
--- a/Makefile
+++ b/Makefile
@@ -254,6 +254,9 @@ # we had "elif" things would have been m
 
 ifeq ($(uname_S),Linux)
 	NO_STRLCPY = YesPlease
+	ifeq ($(uname_M),x86_64)
+		USE_PIC = YesPlease
+	endif
 endif
 ifeq ($(uname_S),Darwin)
 	NEEDS_SSL_WITH_CRYPTO = YesPlease
-- 
1.4.1.rc1.g3550-dirty
Previous: Marco RoelandNext: Pavel Roskin
Message 5 of 13 in “Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm”
  1. Makefile: set USE_PIC on Linux x86_64 for linking with Git.pmMarco Roeland, Jun 28, 2006
  2. Junio C HamanoJun 28, 2006
  3. Junio C HamanoJun 28, 2006
  4. Marco RoelandJun 28, 2006
  5. Makefile: set USE_PIC on Linux x86_64 for linking with Git.xsMarco Roeland, Jun 28, 2006
  6. Pavel RoskinJun 28, 2006
  7. Jakub NarebskiJun 29, 2006
  8. Pavel RoskinJun 30, 2006
  9. Jakub NarebskiJun 30, 2006
  10. Marco RoelandJun 28, 2006
  11. Junio C HamanoJun 28, 2006
  12. Sergey VlasovJun 29, 2006
  13. Josef WeidendorferJun 29, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.