git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm

From
MRMarco Roeland <marco.roeland@xs4all.nl>
Date
Jun 28, 2006, 19:08 UTC
Message-ID
<20060628190814.GC5713@fiberbit.xs4all.nl>
In-Reply-To
<7vr719159v.fsf@assigned-by-dhcp.cox.net>
On Wednesday June 28th 2006 Junio C Hamano wrote:
Show 9 quoted lines
> I agree with it in principle but was too lazy to do that myself.
> I wonder it should be inside Linux, though.
> 
> >  ifeq ($(uname_S),Linux)
> >  	NO_STRLCPY = YesPlease
> > +	ifneq (,$(findstring x86_64,$(uname_M)))
> > +		USE_PIC = YesPlease
> > +	endif
> >  endif

Yes, I wondered about that myself. I chose to be on the safe side: I can and have tested this myself on Linux x86-64 but am not sure if it's needed on the BSD's for example.

Even for Linux someone mentioned that probably i386 is the exception in _not_ needing the -fPIC linkage. It might even be specific to the Perl "xs" implementation specifics?

So I should have added "Works for me (TM)"! ;-)
-- 
Marco Roeland
Previous: Jakub NarebskiNext: Junio C Hamano
Message 10 of 13 in “Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm”
  1. Makefile: set USE_PIC on Linux x86_64 for linking with Git.pmMarco Roeland, Jun 28, 2006
  2. Junio C HamanoJun 28, 2006
  3. Junio C HamanoJun 28, 2006
  4. Marco RoelandJun 28, 2006
  5. Makefile: set USE_PIC on Linux x86_64 for linking with Git.xsMarco Roeland, Jun 28, 2006
  6. Pavel RoskinJun 28, 2006
  7. Jakub NarebskiJun 29, 2006
  8. Pavel RoskinJun 30, 2006
  9. Jakub NarebskiJun 30, 2006
  10. Marco RoelandJun 28, 2006
  11. Junio C HamanoJun 28, 2006
  12. Sergey VlasovJun 29, 2006
  13. Josef WeidendorferJun 29, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.