Re: What's cooking in git.git (Apr 2013, #05; Mon, 15)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 15, 2013, 23:14 UTC
- Message-ID
- <7vip3npet0.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAMP44s2_wiNr4RaBOEnKnZzT4CF0qKK+bp+Lyi=Nfx3Q9ggqOQ@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> And about this: > http://mid.gmane.org/1365638832-9000-3-git-send-email-felipe.contreras@gmail.com
What about it? Is that the one you said you are going to reroll?
I do not recall the details of Peff's complaints, but re-reading the log message of the patch itself, seeing "correctly" twice is not satisfactory. As you very well know, a bug description that says "This does not correctly work!" and stops there is not as useful as a description that defines what "correct" behaviour is expected.
If one of them said "update correctly to record what was pushed" or something like that, that should be sufficient.