git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-lib.sh - define and use GREP_STRIPS_CR

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 21, 2013, 21:04 UTC
Message-ID
<7vip03sjyk.fsf@alter.siamese.dyndns.org>
In-Reply-To
<51EAE7F6.3080509@ramsay1.demon.co.uk>
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 13 quoted lines
> Mark Levedahl wrote:
>> Define a common macro for grep needing -U to allow tests to not need
>> to inquire of specific platforms needing this option. Change
>> t3032 and t5560 to use this rather than testing explicitly for mingw.
>> This fixes these two tests on Cygwin.
>> 
>> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
>> ---
>> This replaces my earlier patch against t3032 (8896b287 on pu)
>
> Yep, this looks good and (as expected) it works on cygwin 1.5 too. :-D
>
> Thanks.

After this patch lands 'master', we may want to add a note to these SED/GREP workarounds for CRLF platforms that we assume the platform use GNU sed/grep.

Incidentally, don't we also need "unset SED_OPTIONS" in t/test-lib.sh net to where we unset GREP_OPTIONS?

Previous: Ramsay JonesNext: Ramsay Jones
Message 10 of 14 in “t3032 incompatible with Cygwin/Windows”
  1. Mark LevedahlJul 16, 2013
  2. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  3. Jonathan NiederJul 16, 2013
  4. Mark LevedahlJul 16, 2013
  5. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  6. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  7. Junio C HamanoJul 17, 2013
  8. test-lib.sh - define and use GREP_STRIPS_CRMark Levedahl, Jul 18, 2013
  9. Ramsay JonesJul 20, 2013
  10. Junio C HamanoJul 21, 2013
  11. Ramsay JonesJul 18, 2013
  12. Mark LevedahlJul 18, 2013
  13. Jonathan NiederJul 16, 2013
  14. Ramsay JonesJul 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.