From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 21 Jul 2013 21:04:51 GMT
Subject: Re: [PATCH] test-lib.sh - define and use GREP_STRIPS_CR
Message-ID: <7vip03sjyk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <51EAE7F6.3080509@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

> Mark Levedahl wrote:
>> Define a common macro for grep needing -U to allow tests to not need
>> to inquire of specific platforms needing this option. Change
>> t3032 and t5560 to use this rather than testing explicitly for mingw.
>> This fixes these two tests on Cygwin.
>> 
>> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
>> ---
>> This replaces my earlier patch against t3032 (8896b287 on pu)
>
> Yep, this looks good and (as expected) it works on cygwin 1.5 too. :-D
>
> Thanks.

After this patch lands 'master', we may want to add a note to these
SED/GREP workarounds for CRLF platforms that we assume the platform
use GNU sed/grep.

Incidentally, don't we also need "unset SED_OPTIONS" in
t/test-lib.sh net to where we unset GREP_OPTIONS?