git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3032 - make compatible with systems using \r\n as a line ending

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Jul 18, 2013, 19:19 UTC
Message-ID
<51E83FA7.5080706@ramsay1.demon.co.uk>
In-Reply-To
<20130716185933.GO14690@google.com>
Jonathan Nieder wrote:
Show 10 quoted lines
> Mark Levedahl wrote:
> 
>> Subtests 6, 7, and 9 rely test that merge-recursive correctly
>> ignores whitespace when so directed. Change the particular whitespace
>> sequences to be ones that are not known line endings so the whitespace
>> is not changed when being extracted by line oriented grep.
> 
> merge-recursive needs to be able to deal with \r at EOL, too, so if at
> all possible I would prefer to see the test fixed to pass on Cygwin
> some other way.

Maybe use -U/--binary option to grep? Indeed, if you look at the top of that test file, you will see:

    test_have_prereq SED_STRIPS_CR && SED_OPTIONS=-b
    test_have_prereq MINGW && export GREP_OPTIONS=-U

which may explain why it works for me on MinGW, but not why it works on cygwin 1.5.

ATB, Ramsay Jones

Previous: Junio C HamanoNext: Mark Levedahl
Message 11 of 14 in “t3032 incompatible with Cygwin/Windows”
  1. Mark LevedahlJul 16, 2013
  2. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  3. Jonathan NiederJul 16, 2013
  4. Mark LevedahlJul 16, 2013
  5. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  6. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  7. Junio C HamanoJul 17, 2013
  8. test-lib.sh - define and use GREP_STRIPS_CRMark Levedahl, Jul 18, 2013
  9. Ramsay JonesJul 20, 2013
  10. Junio C HamanoJul 21, 2013
  11. Ramsay JonesJul 18, 2013
  12. Mark LevedahlJul 18, 2013
  13. Jonathan NiederJul 16, 2013
  14. Ramsay JonesJul 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.