git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] test-lib.sh - define and use GREP_STRIPS_CR

From
Mark Levedahl <mlevedahl@gmail.com>
Date
Jul 18, 2013, 21:44 UTC
Message-ID
<1374183897-11408-1-git-send-email-mlevedahl@gmail.com>
In-Reply-To
<7vtxjt56dc.fsf@alter.siamese.dyndns.org>

Define a common macro for grep needing -U to allow tests to not need to inquire of specific platforms needing this option. Change t3032 and t5560 to use this rather than testing explicitly for mingw. This fixes these two tests on Cygwin.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
This replaces my earlier patch against t3032 (8896b287 on pu)
 t/t3032-merge-recursive-options.sh | 2 +-
 t/t5560-http-backend-noserver.sh   | 2 +-
 t/test-lib.sh                      | 2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t3032-merge-recursive-options.sh b/t/t3032-merge-recursive-options.sh
index 2b17311..5fd7bbb 100755
--- a/t/t3032-merge-recursive-options.sh
+++ b/t/t3032-merge-recursive-options.sh
@@ -14,7 +14,7 @@ test_description='merge-recursive options
 . ./test-lib.sh
 
 test_have_prereq SED_STRIPS_CR && SED_OPTIONS=-b
-test_have_prereq MINGW && export GREP_OPTIONS=-U
+test_have_prereq GREP_STRIPS_CR && export GREP_OPTIONS=-U
 
 test_expect_success 'setup' '
 	conflict_hunks () {
diff --git a/t/t5560-http-backend-noserver.sh b/t/t5560-http-backend-noserver.sh
index ef98d95..9be9ae3 100755
--- a/t/t5560-http-backend-noserver.sh
+++ b/t/t5560-http-backend-noserver.sh
@@ -5,7 +5,7 @@ test_description='test git-http-backend-noserver'
 
 HTTPD_DOCUMENT_ROOT_PATH="$TRASH_DIRECTORY"
 
-test_have_prereq MINGW && export GREP_OPTIONS=-U
+test_have_prereq GREP_STRIPS_CR && export GREP_OPTIONS=-U
 
 run_backend() {
 	echo "$2" |
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 2d63307..1abea40 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -824,6 +824,7 @@ case $(uname -s) in
 	test_set_prereq MINGW
 	test_set_prereq NOT_CYGWIN
 	test_set_prereq SED_STRIPS_CR
+	test_set_prereq GREP_STRIPS_CR
 	;;
 *CYGWIN*)
 	test_set_prereq POSIXPERM
@@ -831,6 +832,7 @@ case $(uname -s) in
 	test_set_prereq NOT_MINGW
 	test_set_prereq CYGWIN
 	test_set_prereq SED_STRIPS_CR
+	test_set_prereq GREP_STRIPS_CR
 	;;
 *)
 	test_set_prereq POSIXPERM
-- 
1.8.3.2.0.13
Previous: Junio C HamanoNext: Ramsay Jones
Message 8 of 14 in “t3032 incompatible with Cygwin/Windows”
  1. Mark LevedahlJul 16, 2013
  2. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  3. Jonathan NiederJul 16, 2013
  4. Mark LevedahlJul 16, 2013
  5. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  6. t3032 - make compatible with systems using \r\n as a line endingMark Levedahl, Jul 16, 2013
  7. Junio C HamanoJul 17, 2013
  8. test-lib.sh - define and use GREP_STRIPS_CRMark Levedahl, Jul 18, 2013
  9. Ramsay JonesJul 20, 2013
  10. Junio C HamanoJul 21, 2013
  11. Ramsay JonesJul 18, 2013
  12. Mark LevedahlJul 18, 2013
  13. Jonathan NiederJul 16, 2013
  14. Ramsay JonesJul 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.