Re: [PATCH] t8005: use more portable character encoding names
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 22, 2009, 16:22 UTC
- Message-ID
- <7vhbzd85ux.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <WnZxv4G_GKTN4oHhxHO_HuQt0cTqurrqXf2HHDiHLAzdp7wC70aKuqDot7xQ1nG9C8_NASCL1_Q@cipher.nrlssc.navy.mil>
Brandon Casey <casey@nrlssc.navy.mil> writes:
Show 6 quoted lines
> ... I hesitate to send it since it does not actually allow any > tests to pass which were previously failing for me. At least the utf-8 to > UTF-8 shouldn't cause any harm. The shift-jis to SJIS seems to be commonly > supported? at least IRIX 6.5 and Solaris as old as 7 recognize it, but the > evidence is only empirical. Modern Solaris, and of course Linux recognize > either.
Perhaps the test can be changed from using cp1251 (whatever that is) to something more common (e.g. 8859-1)?
There was another more large-ish patch to the tests around this area recently from you. I liked them but somehow failed to queue any of them yet, sorry.