Re: [PATCH 2/2] t8005: convert CP1251 character set to ISO8859-5

From: Jeff King <peff@peff.net>
Date: May 25, 2009, 09:20 UTC
Message-ID: <20090525092027.GA22382@coredump.intra.peff.net>
In-Reply-To: <7vhbzc4oht.fsf@alter.siamese.dyndns.org>

On Fri, May 22, 2009 at 06:06:06PM -0700, Junio C Hamano wrote:

Show 5 quoted lines

> It also appears that we do not need OLD_ICONV anymore, as our Makefile
> suggests for older releases.
> 
> It would be nice if people with older Solaris can check if I am not
> breaking things for them...

Git builds fine on my Solaris 8 test box with this patch. It also builds fine if I drop OLD_ICONV, so it may be that we can unconditionally do so (but I don't have any older boxen to test with).

With current 'next' and NO_PERL set, I can pass every test except:

  t3900 - still problems in the eucJP test. I haven't looked closely,
          but my understanding is that this might need extra language
          packs installed (I know virtually nothing about Solaris
          administration and the box is not mine).

  t8005 - git produces incorrect (or at least not expected) results for
          the iso8859-5 to sjis conversion. It all looks like control
          characters to me, so I'm not sure how to diagnose (and it may
          just be an installation issue again).

  t4116,t5000,t5001 - Solaris tar doesn't like pax headers that
                      git-archive generates

  t7700 - seems to be some problem invoking touch. This might be easily
          fixable, so I'll look into it.

-Peff