Re: [PATCH 2/2] t8005: convert CP1251 character set to ISO8859-5

From: Jeff King <peff@peff.net>
Date: May 28, 2009, 18:43 UTC
Message-ID: <20090528184334.GB13499@coredump.intra.peff.net>
In-Reply-To: <zik8bR55cIiktB2euEByCZIZJ1jtx64yA5n1Ki8IMrW1wLBzuBR8Yw@cipher.nrlssc.navy.mil>

On Tue, May 26, 2009 at 09:56:26AM -0500, Brandon Casey wrote:

Show 14 quoted lines

> It also appears from looking at /usr/include/iconv.h that Solaris 10 does
> not need it as long as _XPG6 is defined since that file has:
> 
>   #ifdef _XPG6
>   extern size_t   iconv(iconv_t, char **_RESTRICT_KYWD,
>                   size_t *_RESTRICT_KYWD, char **_RESTRICT_KYWD,
>                   size_t *_RESTRICT_KYWD);
>   #else
>   extern size_t   iconv(iconv_t, const char **_RESTRICT_KYWD,
>                   size_t *_RESTRICT_KYWD, char **_RESTRICT_KYWD,
>                   size_t *_RESTRICT_KYWD);
>   #endif
> 
> I haven't tested, but I will.  I think Solaris 7 needs it though.

Hmph. On Solaris 8, there is no such conditional; iconv is defined similar to the second version you quoted above:

  extern size_t iconv(iconv_t, const char **, size_t *, char **, size_t *);

So it would seem we do need OLD_ICONV there. But it compiles just fine without any warnings.

Show 6 quoted lines

> >   t3900 - still problems in the eucJP test. I haven't looked closely,
> >           but my understanding is that this might need extra language
> >           packs installed (I know virtually nothing about Solaris
> >           administration and the box is not mine).
> 
> t3900.2[23] ?

Yes.

Show 13 quoted lines

> The iconv libraries seem to be named according to the conversions that
> they can perform.  So in /usr/lib/iconv/ you'll see:
> 
>    UTF-8%eucJP.so
>    eucJP%UTF-8.so
>    ISO-2022-JP%UTF-8.so
>    UTF-8%ISO-2022-JP.so
>    etc.
> 
> but you won't see (at least I don't)
> 
>    eucJP%ISO-2022-JP.so
>    ISO-2022-JP.so%eucJP

Ah, I didn't know about that. Thanks. I also have the ones for UTF-8 conversion, but not for direct eucJP to ISO-2022-JP conversion.

Show 9 quoted lines

> >   t8005 - git produces incorrect (or at least not expected) results for
> >           the iso8859-5 to sjis conversion. It all looks like control
> >           characters to me, so I'm not sure how to diagnose (and it may
> >           just be an installation issue again).
> 
> t8005.[23]
> 
> Same reason as above, no conversion between ISO8859-5 and SJIS.  t8005.4
> passes since conversion for both of those to UTF-8 is installed.

OK, makes sense.

> On Solaris 7, I additionally must skip:
> 
>    t5100.[56] t5100.1[026-9] t5100.2[0-6]

Those work just fine for me on Solaris 8.

> Also, if you want to test with the Korn shell (you'll need a couple minor
> tweaks to the test lib), t6030.1[23] must be skipped.  It seems even Solaris

I do all of my testing with bash, having given up on Solaris /bin/sh. In fact, I have found that bash 2.05 works, but bash 2.03 does _not_ (it doesn't like sourcing the files with non-ascii characters in t8005.

-Peff