Re: [PATCH] t8005: use more portable character encoding names

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: May 22, 2009, 16:51 UTC
Message-ID: <1vlRZ6iKMvKwtgMEJxvNoDcPRfAVCJ39d4srmMwFYEWx2SenNTUkig@cipher.nrlssc.navy.mil>
In-Reply-To: <7vhbzd85ux.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 11 quoted lines

> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
>> ...  I hesitate to send it since it does not actually allow any
>> tests to pass which were previously failing for me.  At least the utf-8 to
>> UTF-8 shouldn't cause any harm.  The shift-jis to SJIS seems to be commonly
>> supported?  at least IRIX 6.5 and Solaris as old as 7 recognize it, but the
>> evidence is only empirical.  Modern Solaris, and of course Linux recognize
>> either.
> 
> Perhaps the test can be changed from using cp1251 (whatever that is) to
> something more common (e.g. 8859-1)?

Good idea.

> There was another more large-ish patch to the tests around this area
> recently from you.  I liked them but somehow failed to queue any of them
> yet, sorry.

You've got them in 'next'. Did you forget? :) or don't you consider that queued?

-brandon