git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 11, 2013, 18:09 UTC
Message-ID
<7vhah4bjtf.fsf@alter.siamese.dyndns.org>
In-Reply-To
<vpq1u8838rv.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 7 quoted lines
>>       my ($namespace) = @_;
>> 	my $namespace = shift;
>>
>> My impression has been that both are equally common,
>
> The second is the most common in git-remote-mediawiki (but I don't have
> any preference nor know what is recommended elsewhere).

I wasn't implying I prefer the former. I was just being curious, and if the latter is more prevalent in the code _and_ Perlcritique does not have any issue with it, it is perfectly fine.

Thanks.
Previous: Matthieu MoyNext: Célestin Matte
Message 11 of 48 in “Follow perlcritic's recommandations”
  1. 00/28 Follow perlcritic's recommandationsCélestin Matte, Jun 9, 2013
  2. 01/28 git-remote-mediawiki: Make a regexp clearerCélestin Matte, Jun 9, 2013
  3. 02/28 git-remote-mediawiki: Move "use warnings;" before any instructionCélestin Matte, Jun 9, 2013
  4. 03/28 git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8)Célestin Matte, Jun 9, 2013
  5. 04/28 git-remote-mediawiki: Always end a subroutine with a returnCélestin Matte, Jun 9, 2013
  6. 05/28 git-remote-mediawiki: Move a variable declaration at the top of the codeCélestin Matte, Jun 9, 2013
  7. 06/28 git-remote-mediawiki: Change syntax of map callsCélestin Matte, Jun 9, 2013
  8. 07/28 git-remote-mediawiki: Rewrite unclear line of instructionsCélestin Matte, Jun 9, 2013
  9. Junio C HamanoJun 11, 2013
  10. Matthieu MoyJun 11, 2013
  11. Junio C HamanoJun 11, 2013
  12. Célestin MatteJun 11, 2013
  13. Junio C HamanoJun 11, 2013
  14. 08/28 git-remote-mediawiki: Remove useless regexp modifier (m)Célestin Matte, Jun 9, 2013
  15. 09/28 git-remote-mediawiki: Change the behaviour of a splitCélestin Matte, Jun 9, 2013
  16. Matthieu MoyJun 10, 2013
  17. 10/28 git-remote-mediawiki: Change separator of some regexpsCélestin Matte, Jun 9, 2013
  18. 11/28 git-remote-mediawiki: Change style in a regexpCélestin Matte, Jun 9, 2013
  19. 12/28 git-remote-mediawiki: Change style in a regexpCélestin Matte, Jun 9, 2013
  20. 13/28 git-remote-mediawiki: Add newline in the end of die() error messagesCélestin Matte, Jun 9, 2013
  21. 14/28 git-remote-mediawiki: Change the name of a variableCélestin Matte, Jun 9, 2013
  22. 15/28 git-remote-mediawiki: Turn double-negated expressions into simple expressionsCélestin Matte, Jun 9, 2013
  23. 16/28 git-remote-mediawiki: Remove unused variable $entryCélestin Matte, Jun 9, 2013
  24. 17/28 git-remote-mediawiki: Rename a variable ($last) which has the name of a keywordCélestin Matte, Jun 9, 2013
  25. 18/28 git-remote-mediawiki: Assign a variable as undef and make proper indentationCélestin Matte, Jun 9, 2013
  26. 19/28 git-remote-mediawiki: Check return value of openCélestin Matte, Jun 9, 2013
  27. 20/28 git-remote-mediawiki: remove import of unused open2Célestin Matte, Jun 9, 2013
  28. 21/28 git-remote-mediawiki: Put long code into a subroutineCélestin Matte, Jun 9, 2013
  29. Junio C HamanoJun 11, 2013
  30. Célestin MatteJun 11, 2013
  31. 22/28 git-remote-mediawiki: Modify strings for a better coding-styleCélestin Matte, Jun 9, 2013
  32. Eric SunshineJun 10, 2013
  33. Célestin MatteJun 10, 2013
  34. Matthieu MoyJun 10, 2013
  35. Célestin MatteJun 10, 2013
  36. Junio C HamanoJun 10, 2013
  37. Benoît PersonJun 10, 2013
  38. Matthieu MoyJun 10, 2013
  39. Junio C HamanoJun 10, 2013
  40. 23/28 git-remote-mediawiki: Brace file handles for print for more clarityCélestin Matte, Jun 9, 2013
  41. 24/28 git-remote-mediawiki: Replace "unless" statements with negated "if" statementsCélestin Matte, Jun 9, 2013
  42. 25/28 git-remote-mediawiki: Don't use quotes for empty stringsCélestin Matte, Jun 9, 2013
  43. 26/28 git-remote-mediawiki: Put non-trivial numeric values in constants.Célestin Matte, Jun 9, 2013
  44. 27/28 git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki")Célestin Matte, Jun 9, 2013
  45. 28/28 git-remote-mediawiki: Clearly rewrite double dereferenceCélestin Matte, Jun 9, 2013
  46. Eric SunshineJun 10, 2013
  47. Matthieu MoyJun 10, 2013
  48. Célestin MatteJun 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.