Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 10, 2013, 08:37 UTC
Message-ID: <vpqk3m2qs2r.fsf@anie.imag.fr>
In-Reply-To: <1370816573-3808-23-git-send-email-celestin.matte@ensimag.fr>

Célestin Matte <celestin.matte@ensimag.fr> writes:

Show 7 quoted lines

> @@ -1285,8 +1285,7 @@ sub get_mw_namespace_id {
>  		# Look at configuration file, if the record for that namespace is
>  		# already cached. Namespaces are stored in form:
>  		# "Name_of_namespace:Id_namespace", ex.: "File:6".
> -		my @temp = split(/\n/, run_git("config --get-all remote."
> -						. $remotename .".namespaceCache"));
> +		my @temp = split(/\n/, run_git("config --get-all remote.${remotename}.namespaceCache"));

I tend to prefer the former, as it avoids long lines (> 80 columns)

Show 7 quoted lines

> @@ -1339,8 +1338,7 @@ sub get_mw_namespace_id {
>  
>  	# Store explicitely requested namespaces on disk
>  	if (!exists $cached_mw_namespace_id{$name}) {
> -		run_git("config --add remote.". $remotename
> -			.".namespaceCache \"". $name .":". $store_id ."\"");
> +		run_git(qq(config --add remote.${remotename}.namespaceCache "${name}:${store_id}"));

Same.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/