Re: [PATCH v3 00/28] Follow perlcritic's recommandations

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 10, 2013, 01:09 UTC
Message-ID: <CAPig+cR1=32TwatmTdVBDnkpkhwtUNyKL_Z9f=V_FPtt_Y-xiA@mail.gmail.com>
In-Reply-To: <1370816573-3808-1-git-send-email-celestin.matte@ensimag.fr>

On Sun, Jun 9, 2013 at 6:22 PM, Célestin Matte <celestin.matte@ensimag.fr> wrote:

> Changes with v2:
> - Remove patch [02/22] about using the Readonly module
> - Split commit [07/22] into 5 different ones

This was easier to review after being split. Thanks.

> - Split commit [14/22] into 2 different ones
> - Patch [17/22] was *not* split: tell me if it is necessary

[now patch 22/28]

You, Matthieu, and Junio should decide, but I again found it time-consuming and onerous to review with all the changes mashed together.

Show 5 quoted lines

> - Remove wrong change in patch [22/22]
>
> Patch about fixing a bug in a regexp (with has been renames "Make a regexp
> clearer"), which had been sent as a separate patch, is reintegrated into this
> series of patches.

Overall, this series was more pleasant and easy to read than previous versions. With the exception of minor comments, questions, and the whitespace noise in 22/28, I did not spot any issues worth mentioning in the remainder of the series.