From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 11 Jun 2013 18:09:48 GMT
Subject: Re: [PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions
Message-ID: <7vhah4bjtf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpq1u8838rv.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

>>       my ($namespace) = @_;
>> 	my $namespace = shift;
>>
>> My impression has been that both are equally common,
>
> The second is the most common in git-remote-mediawiki (but I don't have
> any preference nor know what is recommended elsewhere).

I wasn't implying I prefer the former.  I was just being curious,
and if the latter is more prevalent in the code _and_ Perlcritique
does not have any issue with it, it is perfectly fine.

Thanks.