Re: [RFC/PATCH] tests: add initial bash completion tests
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 12 quoted lines
> What about this instead?
>
> #!/bin/sh
>
> if type bash >/dev/null 2>&1
> then
> # execute inside bash
> [ -z "$BASH" ] && exec bash $0
> else
> echo '1..0 #SKIP skipping bash completion tests; bash not available'
> exit 0
> fi
Please follow the CodingGuidelines and use
test -z "$BASH" && ...
instead.
Other than that, it is very much simple and straight-forward. I like it.
Junio C Hamano <gitster@pobox.com>