From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 06 Apr 2012 23:22:30 GMT
Subject: Re: [RFC/PATCH] tests: add initial bash completion tests
Message-ID: <7vfwcgzbrd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s3-Ji33oG=Os_O9KpxawWzZzmiZ04QMTokQ+K6_x-31MA@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> What about this instead?
>
> #!/bin/sh
>
> if type bash >/dev/null 2>&1
> then
> 	# execute inside bash
> 	[ -z "$BASH" ] && exec bash $0
> else
> 	echo '1..0 #SKIP skipping bash completion tests; bash not available'
> 	exit 0
> fi

Please follow the CodingGuidelines and use

	test -z "$BASH" && ...

instead.

Other than that, it is very much simple and straight-forward.  I like it.