Re: [RFC/PATCH] tests: add initial bash completion tests
- From
Jeff King <peff@peff.net>
- Date
- Apr 6, 2012, 21:34 UTC
- Message-ID
- <20120406213448.GA5436@sigill.intra.peff.net>
- In-Reply-To
- <CAMP44s0n+dyp-QNOPtiKtGX1VNOsM8GJOLLCksqwPArR+FS8ng@mail.gmail.com>
On Sat, Apr 07, 2012 at 12:21:35AM +0300, Felipe Contreras wrote:
Show 10 quoted lines
> On Fri, Apr 6, 2012 at 11:19 PM, Jeff King <peff@peff.net> wrote: > > On Fri, Apr 06, 2012 at 10:28:39PM +0300, Felipe Contreras wrote: > > > I think you need to start with something like: > > > > #!/bin/sh > > That is irrelevant, even if it's '#!/bin/foobar', it wouldn't make any > difference since the actual command would be something like > '$(SHELL_PATH) t9902-completion.sh'.
True; I thought "prove" would run them directly, but even it uses $(SHELL_PATH) to run the tests. However, doesn't that mean your test will fail completely when $(SHELL_PATH) isn't bash?
So yes, the #! isn't relevant to "make test" (though marking it as #!/bin/sh does serve as documentation for what you expect, and does let people with a sane /bin/sh more easily run the test directly).
But my point still stands that you cannot assume that you are running bash, and you need to either find bash, or gracefully exit the test script if it is not available. Anything else will cause "make test" to fail on some systems (and indeed, applying and running your test, it breaks "make test" on my debian box with dash as /bin/sh).
>Plus /bin/sh does not always point to bash, even when bash is available >(see debian).
Yes, that was my point, and why the example code I showed executed bash explicitly instead of relying on $(SHELL_PATH) to be set to it.
-Peff