Re: [RFC/PATCH] tests: add initial bash completion tests

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 7, 2012, 00:02 UTC
Message-ID: <CAMP44s2KjEYsHeufyon8aKj=tL+uuJiVBMnrzbYdePOJs1iZ-A@mail.gmail.com>
In-Reply-To: <7vbon4zb89.fsf@alter.siamese.dyndns.org>

On Sat, Apr 7, 2012 at 2:33 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> What about this instead?
>>>
>>> #!/bin/sh
>>>
>>> if type bash >/dev/null 2>&1
>>> then
>>>      # execute inside bash
>>>      [ -z "$BASH" ] && exec bash $0
>>> else
>>>      echo '1..0 #SKIP skipping bash completion tests; bash not available'
>>>      exit 0
>>> fi
>> ...
>> Other than that, it is very much simple and straight-forward.  I like it.
>
> It probably is even simpler to do it like this.
>
> if test -z "$BASH" && ! exec bash "$0" "$@"

That would exit immediately with an error:

t9902-completion.sh: 6: exec: bash: not found make: *** [t9902-completion.sh] Error 127

-- 
Felipe Contreras