git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] don't append 'opaquelocktoken:' in PUT and MOVE

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 7, 2009, 19:43 UTC
Message-ID
<7veiyavxqq.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<498DA4F9.20104@gmail.com>
Tay Ray Chuan <rctay89@gmail.com> writes:
Show 11 quoted lines
> In 753bc91 ("Remove the requirement opaquelocktoken uri scheme"), the
> lock token is guaranteed to be prefixed with the string
> 'opaquelocktoken:', which propagated down to file path creation
> operations in the remote repository, namely, in start_put (and
> consequently start_move).
>
> These file operations may not be successful, due to the colon ':'
> character in the file path (specifically, in Windows).
>
> This patch ensures that the lock token sans 'opaquelocktoken:' is used
> instead in start_put.

I am not familiar with DAV so I have to wonder who guarantees in the codepath that the string that follows the "opaquelocktoken:" (and any other lock token uri scheme) is without problematic characters, such as a slash (or colon)?

Previous: Tay Ray Chuan
Message 8 of 8 in “don't append 'opaquelocktoken:' in PUT and MOVE”
  1. don't append 'opaquelocktoken:' in PUT and MOVETay Ray Chuan, Feb 7, 2009
  2. Johannes SchindelinFeb 7, 2009
  3. Tay Ray ChuanFeb 7, 2009
  4. Johannes SchindelinFeb 7, 2009
  5. Tay Ray ChuanFeb 7, 2009
  6. Johannes SchindelinFeb 7, 2009
  7. Tay Ray ChuanFeb 7, 2009
  8. Junio C HamanoFeb 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.