From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 07 Feb 2009 19:43:41 GMT
Subject: Re: [PATCH] don't append 'opaquelocktoken:' in PUT and MOVE
Message-ID: <7veiyavxqq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <498DA4F9.20104@gmail.com>

Tay Ray Chuan <rctay89@gmail.com> writes:

> In 753bc91 ("Remove the requirement opaquelocktoken uri scheme"), the
> lock token is guaranteed to be prefixed with the string
> 'opaquelocktoken:', which propagated down to file path creation
> operations in the remote repository, namely, in start_put (and
> consequently start_move).
>
> These file operations may not be successful, due to the colon ':'
> character in the file path (specifically, in Windows).
>
> This patch ensures that the lock token sans 'opaquelocktoken:' is used
> instead in start_put.

I am not familiar with DAV so I have to wonder who guarantees in the
codepath that the string that follows the "opaquelocktoken:" (and any
other lock token uri scheme) is without problematic characters, such as a
slash (or colon)?