Re: [PATCH] don't append 'opaquelocktoken:' in PUT and MOVE
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 7, 2009, 18:04 UTC
- Message-ID
- <alpine.DEB.1.00.0902071903020.10279@pacific.mpi-cbg.de>
- In-Reply-To
- <be6fef0d0902070952l5818e4b7x3048c667661ce31@mail.gmail.com>
Hi,
On Sun, 8 Feb 2009, Tay Ray Chuan wrote:
Show 9 quoted lines
> On Sun, Feb 8, 2009 at 1:03 AM, Johannes Schindelin > <Johannes.Schindelin@gmx.de> wrote: > > > Besides, I have to wonder where request->lock->token is set, and if > > that would not be the better place to fix the issue? > > Are you suggesting perhaps that we revert commit 753bc91? Or perhaps > create another way to access lock tokens, say, get_lock_token(int > prepend_scheme)?
I do not suggest anything like that.
But I _refuse_ to go and investigate a thing that you should know already, and that you should be able to defend, indeed, something you should have defended in the commit message:
Why does request->lock->token have the prefix at all?
Ciao, Dscho