Re: [PATCH] don't append 'opaquelocktoken:' in PUT and MOVE

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 7, 2009, 17:03 UTC
Message-ID: <alpine.DEB.1.00.0902071801570.10279@pacific.mpi-cbg.de>
In-Reply-To: <498DA4F9.20104@gmail.com>

Hi,

On Sat, 7 Feb 2009, Tay Ray Chuan wrote:

Show 10 quoted lines

> diff --git a/http-push.c b/http-push.c
> index eefd64c..10df94a 100644
> --- a/http-push.c
> +++ b/http-push.c
> @@ -558,7 +558,7 @@ static void start_put(struct transfer_request *request)
> 
>  	append_remote_object_url(&buf, remote->url, hex, 0);
>  	strbuf_addstr(&buf, "_");
> -	strbuf_addstr(&buf, request->lock->token);
> +	strbuf_addstr(&buf, request->lock->token + 16);

Umm. This "16" is a little bit too hardcoded for my liking. I mean, it is not even obvious from _this_ hunk why "16" should be correct.

Besides, I have to wonder where request->lock->token is set, and if that would not be the better place to fix the issue?

Ciao, Dscho