Re: [PATCHi v4] git-send-email.perl: make initial In-Reply-To apply only to first email

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 12, 2010, 20:53 UTC
Message-ID: <7veiaqfels.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1289573708-18573-1-git-send-email-ospite@studenti.unina.it>

Antonio Ospite <ospite@studenti.unina.it> writes:

Show 15 quoted lines

> When an initial In-Reply-To is supplied it should apply only to the
> first email, second and subsequent messages should behave just according
> to the --[no-]chain-reply-to setting; this is also what the man page
> says about the --[no-]chain-reply-to option and this is also how the
> correspondent git-format-patch option behaves.
>
> This is the typical behaviour we    |
> want when we send a series with     | [PATCH 0/2] Here is what I did...
> cover letter in reply to some       |   [PATCH 1/2] Clean up and tests
> discussion, the new patch series    |   [PATCH 2/2] Implementation
> should appear as a separate subtree |   [PATCH v2 0/3] Here is a reroll
> in the discussion, look at the v2   |     [PATCH v2 1/3] Clean up
> series in the illustration on the   |     [PATCH v2 2/3] New tests
> right to see what the new behaviour |     [PATCH v2 3/3] Implementation
> ensures.                            |

Yuck.

It is a common trap to think that everybody already knows what you have been suffering from. It certainly is sufficient to show the output after your patch to convince them that your change is a good thing.

IOW, if you do two-column, please do it right ;-). The LHS should show how the output _used to_ look like, so that even people who didn't particulary care (because they never hit the issue) can see why the updated behaviour is desirable.