Re: [PATCH v3] git-send-email.perl: make initial In-Reply-To apply only to first email
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 10, 2010, 19:48 UTC
- Message-ID
- <7v62w5hsd4.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20101110124522.0dff4076.ospite@studenti.unina.it>
Antonio Ospite <ospite@studenti.unina.it> writes:
> ... About the tests, I am going to modify one of your > tests instead of adding another one, is that OK?
It is not just Ok but is preferred; that is a good way to document where the behaviour changed how, and for what reason ;-).
Perhaps an illustration in the documentation may help. Until I read what Matthieu wrote in his message, I didn't quite get why anybody wanted this new behaviour---my understanding of which is to get something like this:
[PATCH 0/2] Here is what I did...
[PATCH 1/2] Clean up and tests
[PATCH 2/2] Implementation
[PATCH v2 0/3] Here is a reroll
[PATCH v2 1/3] Clean up
[PATCH v2 2/3] New tests
[PATCH v2 3/3] Implementationwhen sending the re-rolled series, with the --in-reply-to for [v2 0/3] set to [0/2] of the original. If you illustrate the current behaviour in a similar way in your commit log message, perhaps side-by-side to save vertical space, it would help make it clear why people would want the new behaviour.