Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patches

From: Antonio Ospite <ospite@studenti.unina.it>
Date: Nov 8, 2010, 11:03 UTC
Message-ID: <20101108120308.df67214e.ospite@studenti.unina.it>
In-Reply-To: <20101105214159.GA4457@burratino>

On Fri, 5 Nov 2010 16:41:59 -0500 Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 20 quoted lines

> Hi Antonio,
> 
> Antonio Ospite wrote:
> > Junio C Hamano <gitster@pobox.com> wrote:
> 
> >> You are breaking the && chain here.
> >
> > Some other tests do that as well, the last line is a command by
> > itself not and-chained with the git-send-email invocation. I guess the
> > logic behind this is that the test succeeds if the _last_ command
> > succeeds. If this is wrong then some other tests are affected too.
> 
> Yes, breaking the && chain is never a good thing.
> 
> See:
> 
>  - t/README: "Chain your test assertions"
>  - v1.5.4~20 (t9001: add missing && operators, 2008-01-21)
>  - git log --grep=&&
>

Thanks Jonathan, I am fixing that also to some other tests in t9001 right now.

Let me know if the v3 in this series is going to be applied as is, so I can fix the newly added test too. If a v4 is needed than I'll fix my test there.

I would also like to point your attention on tests like "confirm by default (due to cc)" and following in t9001, which are storing return value of an intermediate command, how to fix those?

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?