Re: [PATCHi v4] git-send-email.perl: make initial In-Reply-To apply only to first email

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 12, 2010, 21:44 UTC
Message-ID: <7v1v6qfc9e.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1289573708-18573-1-git-send-email-ospite@studenti.unina.it>

Antonio Ospite <ospite@studenti.unina.it> writes:

Show 17 quoted lines

> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 26c2e93..5e48318 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -324,9 +324,11 @@ test_expect_success $PREREQ 'In-Reply-To without --chain-reply-to' '
>  		--smtp-server="$(pwd)/fake.sendmail" \
>  		$patches $patches $patches \
>  		2>errors &&
> -	# All the messages are replies to --in-reply-to
> +	# The first message is a reply to --in-reply-to
>  	sed -n -e "s/^In-Reply-To: *\(.*\)/\1/p" msgtxt1 >actual &&
>  	test_cmp expect actual &&
> +	# Second and subsequent messages are replies to the first one
> +	sed -n -e "s/^Message-Id: *\(.*\)/\1/p" msgtxt1 >expect &&
>  	sed -n -e "s/^In-Reply-To: *\(.*\)/\1/p" msgtxt2 >actual &&
>  	test_cmp expect actual &&
>  	sed -n -e "s/^In-Reply-To: *\(.*\)/\1/p" msgtxt3 >actual &&

Looks good ;-)

I'll do the obvious fix-up (below) at my end, so if there is nothing else there is no need to resend.

    Look at the v2 series in the illustration to see what the new behavior
    ensures:

           (before the patch)          |      (after the patch)
     [PATCH 0/2] Here is what I did... | [PATCH 0/2] Here is what I did...
       [PATCH 1/2] Clean up and tests  |   [PATCH 1/2] Clean up and tests
       [PATCH 2/2] Implementation      |   [PATCH 2/2] Implementation
       [PATCH v2 0/3] Here is a reroll |   [PATCH v2 0/3] Here is a reroll
       [PATCH v2 1/3] Clean up         |     [PATCH v2 1/3] Clean up
       [PATCH v2 2/3] New tests        |     [PATCH v2 2/3] New tests
       [PATCH v2 3/3] Implementation   |     [PATCH v2 3/3] Implementation

    This is the typical behaviour we want when we send a series with cover
    letter in reply to some discussion, the new patch series should appear
    as a separate subtree in the discussion.

Thanks.