Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 11, 2013, 21:41 UTC
Message-ID: <7vehgmle8z.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130211210621.GC32740@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 25 quoted lines

> On Mon, Feb 11, 2013 at 12:59:55PM -0800, Matt Kraai wrote:
>
>> From: Matt Kraai <matt.kraai@amo.abbott.com>
>> 
>> QNX 6.3.2 through 6.5.0 include Expat 1.1, which provides xmlparse.h
>> instead of expat.h, so include the former on QNX systems.
>
> So it is not just QNX, but rather older versions of expat?
>
>> diff --git a/http-push.c b/http-push.c
>> index 9923441..55c575e 100644
>> --- a/http-push.c
>> +++ b/http-push.c
>> @@ -11,7 +11,11 @@
>>  #include "list-objects.h"
>>  #include "sigchain.h"
>>  
>> +#ifndef __QNX__
>>  #include <expat.h>
>> +#else
>> +#include <xmlparse.h>
>> +#endif
>
> If that is the case, should this #ifdef look for EXPAT_NEEDS_XMLPARSE_H,
> and that macro triggered externally?

Heh, our mails crossed. Another thing neither of us mentioned is how compatible the subset of libexpat our codebase uses to what was offered by the older versions of expat. I would not be surprised if nobody has tried running the resulting binary linked with expat 1.