Re: [PATCH] Include xmlparse.h instead of expat.h on QNX
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 11, 2013, 21:53 UTC
- Message-ID
- <7v38x2ldow.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20130211214948.GB19113@ftbfs.org>
Matt Kraai <kraai@ftbfs.org> writes:
Show 6 quoted lines
>> Assuming that this change is about building with expat1, it would >> probably be better to do something like this instead, I would think. > > expat 1.95.0 through 1.95.8 used expat.h; should I still use > EXPAT_VERSION = 1 to signify that it should use xmlparse.h, use > EXPAT_NEEDS_XMLPARSE_H as Jeff suggested, or something else entirely?
Oh, please do not take it as a request to use that exact name (in case you didn't know, I am bad at naming things). It was merely an illustration to show the direction, written without knowing that Peff was essentially giving the same suggestion.
Thanks.
Oh, by the way, please do not deflect an attempt to directly send a response to you with a Mail-Followup-To header.