git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add mksnpath and git_snpath which allow to specify the output buffer

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 28, 2008, 03:35 UTC
Message-ID
<7vd4hlgzo7.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20081027064537.GA4751@blimp.localdomain>
Alex Riesen <raa.lkml@gmail.com> writes:
Show 10 quoted lines
> Junio C Hamano, Mon, Oct 27, 2008 06:07:24 +0100:
>> Where is git_snpath() used?
>
> Nowhere yet, but it should replace git_path in every call where the
> result is not used immediately. Which, as the story with cygwin
> porting shows, can be sometimes not quite trivial (who could suspect
> lstat(2) will have application local side effects?).
>
> Maybe I should resend the patches without it, following by patches
> introducing git_snpath and replacing calls to git_path.
I took the liberty of doing the first half of just that ;-)

I also think this series of fix is maint-worthy, and splitted the last one into two so that maint and master can be fixed independently.

Previous: Alex RiesenNext: Alex Riesen
Message 8 of 10 in “Add mksnpath and git_snpath which allow to specify the output buffer”
  1. Add mksnpath and git_snpath which allow to specify the output bufferAlex Riesen, Oct 26, 2008
  2. Fix mkpath abuse in dwim_ref and dwim_log of sha1_name.cAlex Riesen, Oct 26, 2008
  3. Fix potentially dangerous uses of mkpath and git_pathAlex Riesen, Oct 26, 2008
  4. Johannes SixtOct 27, 2008
  5. Alex RiesenOct 27, 2008
  6. Junio C HamanoOct 27, 2008
  7. Alex RiesenOct 27, 2008
  8. Junio C HamanoOct 28, 2008
  9. Alex RiesenOct 28, 2008
  10. Alex RiesenOct 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.